Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change single-document toggle shortcut to something more innocuous. #3889

Merged
merged 1 commit into from Feb 26, 2018

Conversation

@afshin
Copy link
Member

@afshin afshin commented Feb 18, 2018

Because users sometimes land themselves in single-document mode with the current keyboard shortcut unintentionally, this PR changes the default to something less likely to be triggered accidentally.

Fixes #3695

@afshin afshin added this to the Beta 2 milestone Feb 18, 2018
@afshin afshin self-assigned this Feb 18, 2018
@blink1073
Copy link
Member

@blink1073 blink1073 commented Feb 26, 2018

Thanks!

@blink1073 blink1073 merged commit e0e0741 into jupyterlab:master Feb 26, 2018
2 checks passed
@afshin afshin deleted the issue-3695 branch Jul 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants