Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make notebook some context menus global #3909

Merged
merged 1 commit into from Feb 20, 2018

Conversation

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Feb 20, 2018

Addresses #3765

Currently, "Clear All Outputs", "Enable Scrolling for Outputs", and "Disable Scrolling for Outputs" context menus only show up when you right-click on a code cell. This changes them to show up when you right-click anywhere in the notebook.

It does this by making them global and re-ordering those options so that they show up between the existing global menu items and the current cell menu items. This preserves the grouping of "Clear Outputs" and "Clear All Outputs" when a code cell is selected.

Code cell

Old

screen shot 2018-02-20 at 4 19 59 pm

New

screen shot 2018-02-20 at 4 11 57 pm

Other cell

Old

screen shot 2018-02-20 at 4 19 51 pm

New

screen shot 2018-02-20 at 4 11 51 pm

Outside of cells

Old

screen shot 2018-02-20 at 4 20 06 pm

New

screen shot 2018-02-20 at 4 12 03 pm

Currently, "Clear All Outputs", "Enable Scrolling for Outputs", and
"Disable Scrolling for Outputs" context menus only show up
when you right click on a code cell. This changes them to show up when
you right click anywhere in the notebook.

It does this by making them global and re-ordering those options
so that they show up between the existing global menu items and the
current cell menu items. This preserves the grouping of "Clear Outputs"
and "Clear All Outputs" when a code cell is selected.
@saulshanabrook saulshanabrook changed the title Make notebook some context menus global (#3765) Make notebook some context menus global (addresses #3765) Feb 20, 2018
@saulshanabrook saulshanabrook changed the title Make notebook some context menus global (addresses #3765) Make notebook some context menus global Feb 20, 2018
Copy link
Member

@blink1073 blink1073 left a comment

Looks good, thanks!

Loading

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Feb 20, 2018

Thanks! Maybe "Clear All Outputs" in the "outside all cells mode" as well?

Loading

@blink1073
Copy link
Member

@blink1073 blink1073 commented Feb 20, 2018

@ellisonbg, I'm confused, "Clear All Outputs" is shown when clicked outside all of the cells in this PR.

Loading

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Feb 20, 2018

No I am unable to read ;-) Merge away!!!

Loading

@blink1073
Copy link
Member

@blink1073 blink1073 commented Feb 20, 2018

Great, merging!

Loading

@blink1073 blink1073 merged commit 559cddc into jupyterlab:master Feb 20, 2018
2 checks passed
Loading
@saulshanabrook saulshanabrook deleted the notebook-context-menus branch Feb 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants