Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of progress bars #4045

Merged
merged 2 commits into from Feb 27, 2018
Merged

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Feb 27, 2018

Fixes #3902.

Reverts part of #3882 to the previous, more performant handling of carriage returns. Also uses a box panel for the notebook panel to avoid browser calculations.

@blink1073 blink1073 added this to the Beta 2 milestone Feb 27, 2018
@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Feb 27, 2018

This fixes #3902, and keeps the fix for #3881. It seems to regress #3718, though.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Feb 27, 2018

Ah, right, looking into it.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Feb 27, 2018

Updated.

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Feb 27, 2018

Looks good to me. Do you have any insight as to how those multiple carriage-returns were getting in there?
(using the example from that issue)

a = "foo\r\nbar\r\n"*5
with open('foo.txt', 'w') as f:
    f.write(a)
    
!cat foo.txt

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Feb 27, 2018

I used print('a\r\r\n') to verify the fix. I think Vidar's comment is the best idea we had.

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Feb 27, 2018

Thanks!

@ian-r-rose ian-r-rose merged commit 1e8a365 into jupyterlab:master Feb 27, 2018
2 checks passed
@blink1073 blink1073 deleted the notebook-boxpanel branch Jul 16, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants