Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make comms asynchronous #4115

Merged
merged 1 commit into from Mar 15, 2018
Merged

Make comms asynchronous #4115

merged 1 commit into from Mar 15, 2018

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Mar 5, 2018

Fixes #3884.

@blink1073 blink1073 added this to the Beta 2 milestone Mar 5, 2018
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Mar 15, 2018

Once the comm processing is async, the whole message processing chain needs to be async to preserve order. Before we go down that route, as a thought experiment, what would happen if we didn't make it async? Right now, the only thing requiring async processing in comms for me is that we are splitting off the widget controls as a separate webpack bundle, which is loaded async. Unlike the classic notebook, where plugins are all loaded async, we webpack everything together in jlab.

However, this is in the core services repo. It's entirely possible (such as in the html widget manager) this could be used in contexts where async loading and processing is much more natural. I guess for that reason we should continue down the path of all async processing.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Mar 15, 2018

This looks good to me. We still need to push the async up further so that all kernel messages are handled async (so all kernel messages are processed in order), but this is an important step in the right direction. Thanks!

@jasongrout jasongrout merged commit c9c199c into jupyterlab:master Mar 15, 2018
2 checks passed
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Mar 15, 2018

I opened an issue for the continued work on async processing in #4188.

jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Jun 16, 2018
It looks like we disabled all tests except the ikernel tests in 9b654f5  (see jupyterlab#4115, jupyterlab@9b654f5#diff-388fcef0ff8fa826feaa68effbcaaf02R30). We forgot to enable them again.
@blink1073 blink1073 deleted the sync-comm branch Jul 16, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants