Correct keyboard shortcuts commands for headings #4430
This PR attempts to fix this problem by changing the command names in
The text was updated successfully, but these errors were encountered:
The proposed changes were based on @jasongrout's suggestions in issue jupyterlab#4428. In `jupyterlab/packages/shortcuts-extension/schema/plugin.json`, keyboard shortcut `1-6` are registered with commands `change-`**`to-cell`**`-heading-X`, whereas the commands in `jupyterlab/packages/notebook-extension/src/index.ts` are named `change-`**`cell-to`**`-heading-X`. As a result, the keyboard shortcuts are not working. This PR attempts to fix this problem by changing the command names in `jupyterlab/packages/shortcuts-extension/schema/plugin.json` to the ones in `jupyterlab/packages/notebook-extension/src/index.ts`.
Based on @jasongrout's suggestions in pull request jupyterlab#4430, the shortcut names for changing headings are changed back to `change-to-cell-heading-X` for compatibility concerns. Quotes from @jasongrout's comment: "Can you leave the names of the shortcuts the same, and just change the 'command' lines, so that if someone overrode the setting, it still is overridden? We'll change the name of the shortcuts in the 0.33 release, since it's a backwards-incompatible change." "That way we can release this fix in a patch release to 0.32, rather than having to wait until 0.33."