Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cancel button for initial kernel selection. #4596

Merged

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented May 17, 2018

Fixes #4157, alternative to #4440. This removes the CANCEL button from the kernel selection upon initial notebook creation. It is still available if you want to change your kernel.

The dialog can still be dismissed by pressing esc, at which point a newly created notebook will still be created, but without a kernel.

cc @tgeorgeux @ellisonbg

@ian-r-rose ian-r-rose added this to the Beta 3 milestone May 17, 2018
Copy link
Contributor

@ellisonbg ellisonbg left a comment

I think this is a good solution. Thanks for working on this!

@tgeorgeux
Copy link
Contributor

@tgeorgeux tgeorgeux commented May 17, 2018

Yep, that'll do it. Thanks Ian.

@ian-r-rose ian-r-rose merged commit 473348d into jupyterlab:master May 17, 2018
2 checks passed
@cancan101
Copy link

@cancan101 cancan101 commented May 17, 2018

Still seems a little gross in the case esc is hit, no?

@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented May 17, 2018

It's not ideal, but our primary goal here was to reduce the confusion about what the dialog box is for. As it is, none of the new activities are cancelable, per se, and we wanted to not make it seem like the kernel selection dialog was able to cancel notebook creation.

@cancan101
Copy link

@cancan101 cancan101 commented May 17, 2018

Maybe eliminate the entire dialog then and just use the selector on the notebook somehow to indicate this isn't dismisisable?

@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented May 17, 2018

The selector on the notebook brings up the same dialog box.

@cancan101
Copy link

@cancan101 cancan101 commented May 17, 2018

Removing the cancel in that case seems not ideal then.

@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented May 17, 2018

This removes the CANCEL for a newly-created notebook, but not for changing it once the notebook has been created. The dialogs are otherwise identical.

@ian-r-rose ian-r-rose mentioned this pull request Jul 20, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants