Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on also checking for IDrives in rendermime. #4613

Merged
merged 3 commits into from May 22, 2018

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented May 21, 2018

Fix for jupyterlab/jupyterlab-github#57.

Our isLocal check was not working properly for recognizing alternative storage backends to the contents manager. This was making relative links incorrect (for an example, see here).

This adds an optional isLocal function to the IRenderMime.IResolver that checks whether a path should be handled by the application, or whether it should be left alone. It performs similarly to URLExt.isLocal, but also checks if the path matches any of the alternative IDrive objects. I think we can get away with making this a minor release to rendermime-interfaces.

afshin
afshin approved these changes May 22, 2018
Copy link
Member

@afshin afshin left a comment

I think this may be the final verse in the saga of whether things are local ...

Definitely a minor version bump.

Thanks! 👍

@afshin afshin merged commit 83c0e8b into jupyterlab:master May 22, 2018
2 checks passed
@jasongrout jasongrout added this to the Beta 3 milestone Jun 12, 2018
@ian-r-rose ian-r-rose mentioned this pull request Jul 20, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants