Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Typescript 2.9 #4675

Merged
merged 14 commits into from Jun 8, 2018
Merged

Upgrade to Typescript 2.9 #4675

merged 14 commits into from Jun 8, 2018

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 1, 2018

Update to typescript 2.9

I also needed to update vega to pull in the newest packages. Since our semver dependency didn't change, and I just wanted to update the yarn.lock with updated versions, I simply deleted the outdated dependencies in the yarn.lock (e.g., all of the vega-* entries) and then did yarn install to update the yarn.lock file with current dependencies.

cf vega/vega-lite#3836

@jasongrout jasongrout changed the title WIP upgrade to Typescript 2.9 Upgrade to Typescript 2.9 Jun 5, 2018
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jun 5, 2018

Found another issue: vega/vega-lite#3855

@jasongrout jasongrout changed the title Upgrade to Typescript 2.9 WIP Upgrade to Typescript 2.9 Jun 5, 2018
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jun 6, 2018

On second thought, I read more carefully the TS 2.7 release notes, in particular about esModuleInterop:

Note: The new behavior is added under a flag to avoid unwarranted breaks to existing code bases. We highly recommend applying it both to new and existing projects. For existing projects, namespace imports (import * as express from "express"; express();) will need to be converted to default imports (import express from "express"; express();)

Also, @domoritz points out a few other references at vega/vega-lite#3855

I think we should probably turn on the esModuleInterop option for our codebase.

@jasongrout jasongrout added this to the Beta 3 milestone Jun 6, 2018
@jasongrout jasongrout force-pushed the ts29 branch 2 times, most recently from 1aed6b2 to f8b67ca Jun 6, 2018
jasongrout added 2 commits Jun 7, 2018
We add this since typedoc uses TS 2.7, which doesn’t understand some of the dependency’s .d.ts files that were generated with TS 2.9.
@jasongrout jasongrout changed the title WIP Upgrade to Typescript 2.9 Upgrade to Typescript 2.9 Jun 7, 2018
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jun 8, 2018

@ian-r-rose, @afshin - I think this is ready for review.

Copy link
Member

@ian-r-rose ian-r-rose left a comment

LGTM, just one question.

@@ -0,0 +1,2 @@
// Copyright (c) Jupyter Development Team.
// Distributed under the terms of the Modified BSD License.
Copy link
Member

@ian-r-rose ian-r-rose Jun 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file for?

Copy link
Contributor Author

@jasongrout jasongrout Jun 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an empty file for the test template package. TS 2.9 now complains that it couldn't find any files to compile, so I added a single empty test file, similar to the one in the package template.

Copy link
Contributor Author

@jasongrout jasongrout Jun 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ian-r-rose ian-r-rose merged commit c080cd5 into jupyterlab:master Jun 8, 2018
2 checks passed
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jun 8, 2018

Yay! Thanks!

@jasongrout jasongrout mentioned this pull request Jun 12, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants