Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin for TSV files view. Closes #4226 and #2746 #4684

Merged
merged 4 commits into from Jun 28, 2018

Conversation

@jirivrany
Copy link
Contributor

@jirivrany jirivrany commented Jun 6, 2018

Finished plugin with suggested changes for a more clean code.

Closes #4226 and #2746, supersedes #4668.

@jasongrout jasongrout added this to the Beta 3 milestone Jun 6, 2018
@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Jun 6, 2018

Thanks for opening this new one. Could you fix the few style issues thare picked up in the ci:

ERROR: packages/csvviewer-extension/src/index.ts[84, 2]: Unnecessary semicolon
ERROR: packages/csvviewer-extension/src/index.ts[120, 2]: Unnecessary semicolon

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 28, 2018

@jirivrany - Thanks! This works great for me.

@jasongrout jasongrout merged commit 30fd2bd into jupyterlab:master Jun 28, 2018
2 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants