Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch json highlighter to use the esModuleInterop default export. #4714

Merged
merged 1 commit into from Jun 12, 2018

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 12, 2018

See #4713. This is what we can do with the esModuleInterop flag - treat that export as an es2015 default export.

@jasongrout jasongrout added this to the Beta 3 milestone Jun 12, 2018
afshin
afshin approved these changes Jun 12, 2018
Copy link
Member

@afshin afshin left a comment

Nice! I didn't know about this. I ran it locally.

@jasongrout jasongrout merged commit 3e1913c into jupyterlab:master Jun 12, 2018
2 checks passed
@jasongrout jasongrout deleted the hightlightimport branch Jun 12, 2018
@jasongrout jasongrout mentioned this pull request Jun 12, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants