Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting editor's layout stretch defaults. #4772

Merged
merged 2 commits into from Jun 26, 2018

Conversation

@afshin
Copy link
Member

@afshin afshin commented Jun 25, 2018

Before:
before

After:
after

@afshin afshin self-assigned this Jun 25, 2018
@afshin afshin force-pushed the setting-editor-stretch branch from 9f389d5 to 4c4b9d6 Jun 25, 2018
@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 25, 2018

Fixes #2971.

Why is it necessary to reset the stretch factor so often? Isn't this a sticky setting?

@afshin
Copy link
Member Author

@afshin afshin commented Jun 25, 2018

@ian-r-rose You are correct, thanks! I think I tried and did something wrong and thought it did not work when I set the stretch factors in the constructor. But it does work on my machine, so I must have been mistaken.

@afshin afshin force-pushed the setting-editor-stretch branch from 104d552 to d263c70 Jun 25, 2018
@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 26, 2018

LGTM, thanks!

@ian-r-rose ian-r-rose merged commit 1af01e5 into jupyterlab:master Jun 26, 2018
2 checks passed
@afshin afshin deleted the setting-editor-stretch branch Jul 5, 2018
@afshin afshin mentioned this pull request Jul 5, 2018
@jasongrout jasongrout added this to the 0.33 milestone Jul 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants