Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL functionality user documentation. #4780

Merged
merged 6 commits into from Jun 28, 2018
Merged

Conversation

@afshin
Copy link
Member

@afshin afshin commented Jun 26, 2018

This PR adds user documentation for workspaces, tree URLs, workspace clone, and workspace reset URLs.

@afshin afshin added this to the Beta 3 milestone Jun 26, 2018
@afshin afshin self-assigned this Jun 26, 2018
@afshin afshin requested a review from jzf2101 Jun 26, 2018
@afshin
Copy link
Member Author

@afshin afshin commented Jun 26, 2018

@choldgraf
Copy link
Contributor

@choldgraf choldgraf commented Jun 26, 2018

woot! lemme know when you'd like a pair of 👀 to review

@afshin afshin changed the title [wip] URL functionality user documentation. URL functionality user documentation. Jun 26, 2018
@afshin
Copy link
Member Author

@afshin afshin commented Jun 26, 2018

@choldgraf I think I'm done with this pass, actually. So please do.

@jzf2101
Copy link
Contributor

@jzf2101 jzf2101 commented Jun 26, 2018

Will pull and build in a bit @afshin

Copy link
Contributor

@jzf2101 jzf2101 left a comment

I'm going to reorganize this for ease of reading since it probably should go in a separate section entirely


.. _urls:

URLs (``/tree``, ``/workspaces``, etc.)
Copy link
Contributor

@jzf2101 jzf2101 Jun 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should be referenced in starting.rst - Also we may want to explain what we mean a little more in the title such as

JupyterLab Server URL


.. _url-tree:

Like the classic notebook, JupyterLab provides a way for users to copy URLs that
Copy link
Contributor

@jzf2101 jzf2101 Jun 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading this again, this probably should be in a separate page entirely and link from the starting JupyterLab section and the interfaces section

@saulshanabrook saulshanabrook merged commit b39eb74 into jupyterlab:master Jun 28, 2018
1 of 2 checks passed
@choldgraf
Copy link
Contributor

@choldgraf choldgraf commented Jun 28, 2018

wohoo!

@afshin
Copy link
Member Author

@afshin afshin commented Jul 2, 2018

cc: #3673

@afshin afshin deleted the url-docs branch Jul 5, 2018
@afshin afshin mentioned this pull request Jul 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants