Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase tab width by 50%. #4801

Merged
merged 1 commit into from Jun 29, 2018
Merged

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 28, 2018

Fixes #2378.

Increases the maximum tab width by 50%, from 144px to 216px. This roughly matches the tab widths in Firefox and Chrome (using the eyeball norm).

cc @tgeorgeux

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 29, 2018

Looks all right to me. Thanks. I'll merge, and @tgeorgeux or @ellisonbg, please comment if you'd rather it be tweaked/changed.

@jasongrout jasongrout merged commit 085e962 into jupyterlab:master Jun 29, 2018
2 checks passed
@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jun 29, 2018

@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented Jun 29, 2018

@ellisonbg
Before:
image
After:
image

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jul 3, 2018

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jul 3, 2018

We have autoshrinking if there are too many. That's why there is a min-width as well as a natural base size: https://github.com/jupyterlab/jupyterlab/pull/4801/files#diff-20c095f9c6bf0094b3429901c78d706bR50

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jul 3, 2018

@ian-r-rose ian-r-rose mentioned this pull request Jul 20, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants