Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to yarn 1.6.0. #4804

Merged
merged 1 commit into from Jun 29, 2018
Merged

Downgrade to yarn 1.6.0. #4804

merged 1 commit into from Jun 29, 2018

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 28, 2018

Fixes #4793

This avoids the bug in yarn noted at yarnpkg/yarn#5935, where a system path can override local paths. This bug can break executing commands from yarn in pipenv environments, for example.

Fixes jupyterlab#4793

This avoids the bug in yarn noted at yarnpkg/yarn#5935, where a system path can override local paths. This bug can break executing commands from yarn in pipenv environments, for example.
@jasongrout jasongrout added this to the Beta 3 milestone Jun 28, 2018
Copy link
Member

@ian-r-rose ian-r-rose left a comment

👍

@ian-r-rose ian-r-rose merged commit b59da1e into jupyterlab:master Jun 29, 2018
2 checks passed
@hadim
Copy link
Contributor

@hadim hadim commented Jul 16, 2018

Are you planning to upgrade to 1.8.0 before the next release? Because I still have this issue with jupyterlab-0.33.0rc0 (and so the bundled yarn 1.6.0).

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jul 16, 2018

We need to see if the serious yarn 1.8 bug noted above affects users building JLab, or just developers. If it affects users, we'll upgrade yarn when 1.9 is released with a fix. If the bug only affects developers, I'd be okay with upgrading and working around the problem for now.

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jul 16, 2018

By the way, that issue is solved by using node 9 or earlier. For example, node lts should work.

@hadim
Copy link
Contributor

@hadim hadim commented Jul 17, 2018

Ok thank you. Ues I have downgraded node and it works. It just misleading since node 10 is the version shipped with conda forge.

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jul 25, 2018

As an update from the yarn issue linked above: 1.9 was released without a fix for the blocker issue for us. If anyone wants to fix the issue in yarn, please feel free to submit a PR to them. An outline of one way to do it is noted in the yarn issue.

@bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jul 25, 2018

@jasongrout jasongrout deleted the yarn16 branch Jul 25, 2018
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jul 31, 2018

@bollwyvl - thanks again for taking a look at the yarn bug!

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants