Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Vega+Vega-Lite #4806

Merged
merged 2 commits into from Jun 29, 2018
Merged

Upgrade Vega+Vega-Lite #4806

merged 2 commits into from Jun 29, 2018

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 29, 2018

Supersedes #4661.

@domoritz This is a continuation of your PR, where I have reverted the changes to package.json and yarn.lock in jupyterlab/staging. That directory should only make reference to published packages, if I understand it correctly. I think this should fix the build issues we were seeing.

@domoritz
Copy link
Member

@domoritz domoritz commented Jun 29, 2018

Thank you!

@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented Jun 29, 2018

Thank you! Sorry it took so long...

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Jun 29, 2018

Will this break Altair support in JupyterLab? It looks like they don't target Vega 4 yet, only vega 3? https://github.com/altair-viz/altair/blob/master/altair/vega/v3/display.py#L17

Am I understanding things right that with this PR JupyterLab wouldn't have anything to handle the 'application/vnd.vega.v3+json' mimetype?

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Jun 29, 2018

I am going to try this with Altair and see if things work.

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Jun 29, 2018

Nevermind, I forgot that Altair outputs vega lite instead of vega.
screen shot 2018-06-29 at 1 28 51 pm

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Jun 29, 2018

This works locally for me with Altair. Thanks for this Ian!

@saulshanabrook saulshanabrook merged commit 6f1ebd8 into jupyterlab:master Jun 29, 2018
2 checks passed
@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented Jun 29, 2018

Thanks for checking @saulshanabrook, and thanks @domoritz!

@ian-r-rose ian-r-rose mentioned this pull request Jul 20, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants