Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new notebook command to command palette #4812

Merged
merged 1 commit into from Jun 29, 2018
Merged

Conversation

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Jun 29, 2018

There is a Console command that starts a new console, so it seems
to make sense to have a corresponding Notebook command that starts
a new notebook.

Issues was raised by @MMesch on gittter

https://gitter.im/jupyterlab/jupyterlab?at=5b363d4abe98b1422413c3a3

There is a `Console` command that starts a new console, so it seems
to make sense to have a corresponding `Notebook` command that starts
a new notebook.

Issues was raised by @MMesch on gittter

https://gitter.im/jupyterlab/jupyterlab?at=5b363d4abe98b1422413c3a3
@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 29, 2018

Looks good to me. That reminds me that I inadvertently added icons for the "create new" items in the command palette, which I want to remove.

@ian-r-rose ian-r-rose merged commit 5b676f6 into master Jun 29, 2018
4 checks passed
@saulshanabrook
Copy link
Member Author

@saulshanabrook saulshanabrook commented Jun 29, 2018

@ian-r-rose Yep, I saw those. Thanks!

@saulshanabrook saulshanabrook deleted the new-notebook-command branch Jun 29, 2018
@jasongrout jasongrout added this to the 0.33 milestone Jul 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants