Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make session.kernelChanged signal include both the old and new kernels. #4834

Merged
merged 1 commit into from Jul 4, 2018

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jul 4, 2018

This makes it much easier to unregister anything (such as comm targets, message hooks, etc.) we had registered on the old kernel before registering such things on the new kernel.

This makes it much easier to unregister anything (such as comm targets, message hooks, etc.) we had registered on the old kernel before registering such things on the new kernel.
@jasongrout jasongrout added this to the Beta 3 milestone Jul 4, 2018
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jul 4, 2018

See the discussion at #4832

afshin
afshin approved these changes Jul 4, 2018
Copy link
Member

@afshin afshin left a comment

Thanks, @jasongrout, this is a good solution to #4832

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jul 4, 2018

Thanks for the review! Tests pass, so merging.

@jasongrout jasongrout merged commit fa67c37 into jupyterlab:master Jul 4, 2018
2 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants