Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup mainmenu api #4890

Merged
merged 2 commits into from Jul 13, 2018
Merged

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jul 12, 2018

This simplifies the main menu API for removing a group to use a DisposableDelegate pattern, rather than the previous removeGroup function. This way is simpler and less error-prone.

Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 67a6e94 into jupyterlab:master Jul 13, 2018
2 checks passed
@jasongrout jasongrout added this to the 0.33 milestone Jul 19, 2018
@ian-r-rose ian-r-rose mentioned this pull request Jul 20, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants