Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize Vega view when the cell gets disposed #4904

Merged
merged 1 commit into from Jul 15, 2018

Conversation

@domoritz
Copy link
Member

@domoritz domoritz commented Jul 15, 2018

Fixes #4897

@domoritz
Copy link
Member Author

@domoritz domoritz commented Jul 15, 2018

The build failures seem unrelated to my change so I'm going to ignore them. Hope that's okay.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jul 15, 2018

Yep, a re-run cleared it up. Thanks!

@blink1073 blink1073 merged commit 20ba7aa into jupyterlab:master Jul 15, 2018
2 checks passed
@jasongrout jasongrout added this to the 0.33 milestone Jul 19, 2018
@ian-r-rose ian-r-rose mentioned this pull request Jul 20, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants