Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "Beta" #4920

Merged
merged 5 commits into from Jul 19, 2018
Merged

remove "Beta" #4920

merged 5 commits into from Jul 19, 2018

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jul 18, 2018

See #4898 for the discussion.

@jasongrout jasongrout changed the title WIP - remove "Beta" [WIP] remove "Beta" Jul 18, 2018
@jasongrout jasongrout added this to the Beta 3 milestone Jul 18, 2018
@blink1073
Copy link
Member

@blink1073 blink1073 commented Jul 19, 2018

This is the only other relevant use of beta that I found: ./packages/help-extension/src/index.tsx:273: let release = 'Beta Release Series';

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Jul 19, 2018

Thanks.

I also fixed the about dialog - the styling from #2550 didn't work anymore because our DOM structure changed, so we had an overflow: auto scrollbar problem. Here's the change in this PR:

Before:
screen shot 2018-07-19 at 5 06 04 am

After:
screen shot 2018-07-19 at 5 02 52 am

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jul 19, 2018

Looks great, thanks!

@blink1073 blink1073 merged commit 2e5b00c into jupyterlab:master Jul 19, 2018
2 checks passed
@jasongrout jasongrout changed the title [WIP] remove "Beta" remove "Beta" Jul 19, 2018
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Jul 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants