Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the busy favicon filename to the template. #4966

Merged
merged 2 commits into from Jul 26, 2018

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jul 26, 2018

Also, make the favicon switching robust against not having the appropriate links on the page.

Fixes #4965

This seems to work in Chrome, but not Firefox. Investigating...

Also, make the favicon switching robust against not having the appropriate links on the page.

Fixes jupyterlab#4695
@jasongrout jasongrout changed the title Move the busy favicon filename to the template. [WIP] Move the busy favicon filename to the template. Jul 26, 2018
@jasongrout jasongrout added this to the 0.33 milestone Jul 26, 2018
@jasongrout jasongrout changed the title [WIP] Move the busy favicon filename to the template. Move the busy favicon filename to the template. Jul 26, 2018
@blink1073
Copy link
Member

@blink1073 blink1073 commented Jul 26, 2018

Thanks!

@blink1073 blink1073 merged commit 7033d40 into jupyterlab:master Jul 26, 2018
1 of 2 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants