Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for cells #50

Merged
merged 24 commits into from Jun 23, 2016
Merged

Tests for cells #50

merged 24 commits into from Jun 23, 2016

Conversation

@afshin
Copy link
Member

@afshin afshin commented Jun 14, 2016

These are the tests for notebook/cells and the subsequents tweaks and bug fixes that they revealed.

File % Stmts % Branch % Funcs %Lines
notebook/cells/ 99.26 86.62 100 99.62
editor.js 100 92.86 100 100
index.js 100 50 100 100
model.js 98.58 91.43 100 100
widget.js 99.29 82.05 100 99.28
@afshin afshin force-pushed the cell-tests branch 4 times, most recently from c16c8d5 to 9b51f15 Jun 16, 2016
@afshin
Copy link
Member Author

@afshin afshin commented Jun 17, 2016

FYI, this PR is on hold because #101 will require it to be rebased and refactored.

@afshin afshin force-pushed the cell-tests branch 3 times, most recently from ff0dcc7 to 976d25a Jun 21, 2016
let widget = new MarkdownCellWidget({ rendermime });
expect(widget.rendered).to.be(true);
requestAnimationFrame(() => {
expect(widget.node.classList.contains(RENDERED_CLASS)).to.be(true);
Copy link
Member

@blink1073 blink1073 Jun 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Async tests need to use done()

Copy link
Member Author

@afshin afshin Jun 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

@afshin afshin force-pushed the cell-tests branch 3 times, most recently from 8caa5b0 to 24a87cc Jun 22, 2016
@blink1073 blink1073 changed the title [work in progress] tests for cells Tests for cells Jun 23, 2016
let widget = new CellEditorWidget(new CellModel());
let called = false;
let event = generate('keydown', { keyCode: UP_ARROW });
widget.edgeRequested.connect(() => { called = true; });
Copy link
Member

@blink1073 blink1073 Jun 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check the signal payload.

Copy link
Member Author

@afshin afshin Jun 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

@afshin afshin self-assigned this Jun 23, 2016
@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 23, 2016

LGTM, thanks!

@blink1073 blink1073 merged commit 8791d9b into jupyterlab:master Jun 23, 2016
1 check passed
@afshin afshin deleted the cell-tests branch Jul 21, 2016
saulshanabrook pushed a commit that referenced this issue Oct 17, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants