Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted Cells Metadata #5037

Merged
merged 17 commits into from Aug 10, 2018
Merged

Deleted Cells Metadata #5037

merged 17 commits into from Aug 10, 2018

Conversation

@richagadgil
Copy link
Contributor

@richagadgil richagadgil commented Aug 2, 2018

Added 'deleted cells' list to Notebook Model, keeps track of deleted cells since notebook last run with the help of NotebookActions @ellisonbg

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Aug 3, 2018

I think I'm missing some context for why this is needed. What's the use case that we are solving here?

@richagadgil
Copy link
Contributor Author

@richagadgil richagadgil commented Aug 3, 2018

The list of deleted cells would help the reactive kernel know when a cell is allowed to redefine variables, or else cells could not redefine variables created in other cells even after the originals had been deleted.

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Aug 5, 2018

To elaborate a bit more. In our design work on a reactive kernel, we worked really hard to find the minimal set of changes to a Jupyter frontend that would be required to support reactive kernels. We are pretty confident we got it down to these two requirements:

  • Cells have unique and persistent ids that are sent along with the kernel execute requests.
  • Kernels can somehow figure out when cell have been deleted each time new code is run.

The exact and full reasons that these two things are required are a bit subtle. More than willing to go into it further, but describing it here would require more text than I have time for right now...

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 7, 2018

Needs a rebase after #5033...

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 7, 2018

Needs a jlpm integrity and commit.

@richagadgil
Copy link
Contributor Author

@richagadgil richagadgil commented Aug 8, 2018

Somehow, running jlpm run integrity did not change my git status

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 9, 2018

Weird, worked on my machine. Pushed the commit.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 10, 2018

Thanks! Note: we now run integrity as part of the commit hook (and it hopefully actually works).

@blink1073 blink1073 merged commit 45a105e into jupyterlab:master Aug 10, 2018
2 checks passed
@blink1073 blink1073 added this to the 0.34 milestone Aug 10, 2018
@richagadgil richagadgil deleted the deletedCells branch Aug 10, 2018
@richagadgil richagadgil mentioned this pull request Aug 15, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants