Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude extensions with "deprecated" in keyword list #5058

Merged
merged 2 commits into from Aug 7, 2018

Conversation

@BoPeng
Copy link
Collaborator

@BoPeng BoPeng commented Aug 6, 2018

#5057

This PR excludes packages from the extensionmanager if it has deprecated in its keyword list. This effectively removes my outdated sos-extension extension from the list.

There can be other criteria such as no valid homepage url, even inaccessible homepage url, or comparing depends with current JLab version, but looking for deprecated is the easiest one and we can implement other criteria later.

@BoPeng BoPeng changed the title Exclude extensions with deprecated in keyword list Exclude extensions with "deprecated" in keyword list Aug 6, 2018
@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 7, 2018

Thanks!

@blink1073 blink1073 merged commit 2c2e42b into jupyterlab:master Aug 7, 2018
2 checks passed
@blink1073 blink1073 added this to the 0.34 milestone Aug 7, 2018
@vidartf
Copy link
Member

@vidartf vidartf commented Aug 9, 2018

FYI / for future reference, note that the official npm deprecation flag is not returned in the search results themselves. However, the GET package metadata query (currently unused on the client side) does include deprecation information. This information also allows to separate between deprecated versions and deprecated packages.

I do not know how the official deprecation mechanism affects the search result.

@BoPeng
Copy link
Collaborator Author

@BoPeng BoPeng commented Aug 9, 2018

Will npm return deprecated packages in their search results?

@vidartf
Copy link
Member

@vidartf vidartf commented Aug 9, 2018

Will npm return deprecated packages in their search results?

It will definitely return packages where only some versions are marked as deprecated. For packages that have been fully deprecated, it does not seem to be included. For example, take a random deprecated package and click any of its tags. The package does not appear in the search results (neither does it appear if you hit the API: https://registry.npmjs.org/-/v1/search?text=keywords:whereis&size=50&from=0).

@blink1073 blink1073 mentioned this pull request Aug 17, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants