Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileModel Upload Progress Patch #5077

Merged
merged 3 commits into from Aug 9, 2018
Merged

Conversation

@richagadgil
Copy link
Contributor

@richagadgil richagadgil commented Aug 8, 2018

When a file upload errors, it stays in the in-progress uploads array until another file is uploaded or chunked. This patch would ensure that a file upload error would result in that file being removed from the model._uploads array immediately. This patch would improve the ability of the status bar file upload widget to correctly update when an upload is occurring and hide when it is not. @ellisonbg

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 9, 2018

I think this should be handled within model.upload, using try/catch block around the await statements, rather than adding more API.

@richagadgil
Copy link
Contributor Author

@richagadgil richagadgil commented Aug 9, 2018

That's a better idea -- made those changes. Thank you!

Copy link
Member

@blink1073 blink1073 left a comment

Looks great, thanks!

@blink1073 blink1073 merged commit 14a08a9 into jupyterlab:master Aug 9, 2018
2 checks passed
@jasongrout jasongrout added this to the 0.34 milestone Aug 9, 2018
@richagadgil richagadgil deleted the fileError branch Aug 9, 2018
@richagadgil richagadgil mentioned this pull request Aug 15, 2018
@richagadgil richagadgil mentioned this pull request Aug 17, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants