Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application theme info #5078

Merged
merged 2 commits into from Aug 9, 2018
Merged

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Aug 8, 2018

cf. discussions in #5069, #3855, #3681, #3458, jupyterlab/jupyterlab-github#30

This adds a themeChanged signal to the application theme manager. It also adds HTML data attributes to the application shell corresponding to the current theme name, as well as whether the theme declares itself to be light or dark. This will allow extension authors to distribute different icons, UI elements, and respond to the current theme.

Copy link
Member

@blink1073 blink1073 left a comment

Nice!

@blink1073 blink1073 merged commit cb36efb into jupyterlab:master Aug 9, 2018
2 checks passed
@ian-r-rose ian-r-rose mentioned this pull request Aug 12, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants