Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of "New Notebook" command in the command palette. #5079

Merged

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Aug 8, 2018

The label and icon were showing up incorrectly for this command in the command palette.

@ian-r-rose ian-r-rose added the bug label Aug 8, 2018
@ian-r-rose ian-r-rose added this to the 0.34 milestone Aug 8, 2018
Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 0bf633f into jupyterlab:master Aug 9, 2018
2 checks passed
@ian-r-rose ian-r-rose mentioned this pull request Aug 12, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants