Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double click to rename #5101

Merged
merged 1 commit into from Aug 11, 2018
Merged

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 11, 2018

Fixes #4605

@blink1073 blink1073 added this to the 0.34 milestone Aug 11, 2018
@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Aug 11, 2018

I haven't been able to reproduce this behavior at all, but apparently several other people can. Weird.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Aug 11, 2018

🤷‍♂️

@blink1073 blink1073 merged commit 142c0bf into jupyterlab:master Aug 11, 2018
2 checks passed
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Aug 11, 2018

I've noticed this recently, so thanks for fixing this.

@blink1073 blink1073 mentioned this pull request Aug 17, 2018
@blink1073 blink1073 deleted the file-double-click branch Sep 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants