Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to file menu #5108

Merged
merged 2 commits into from Aug 13, 2018
Merged

Add to file menu #5108

merged 2 commits into from Aug 13, 2018

Conversation

@marwahaha
Copy link
Contributor

@marwahaha marwahaha commented Aug 12, 2018

fixes #5050

I wasn't sure if this was the right place in the menu.
image

I also am not sure if this will confuse users, who are looking for a dialog that allows for more than just a file path. (i.e. "Why can't I select my file to open?") I wonder if "Open from path" is a more descriptive name. (Users already open files from the Files tab... )

Happy to update whichever way you all decide.

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Aug 12, 2018

Thanks for this PR, I have tagged it for 0.34 and will work on reviewing it.

Loading

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 12, 2018

We could call it Open From Path... for now until we have a better dialog that actually lets you select a path.

Loading

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Aug 12, 2018

Loading

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 13, 2018

Thanks!

Loading

@blink1073 blink1073 merged commit 2e2df6c into jupyterlab:master Aug 13, 2018
1 of 2 checks passed
Loading
@blink1073 blink1073 mentioned this pull request Aug 17, 2018
@marwahaha marwahaha deleted the open-file-menu branch Aug 21, 2018
@jtpio jtpio mentioned this pull request Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants