Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to python 3.5+ #5119

Merged
merged 9 commits into from Aug 14, 2018
Merged

Switch to python 3.5+ #5119

merged 9 commits into from Aug 14, 2018

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 13, 2018

Fixes #2096

Does not yet use async/await since we'll wait to use the utility function force_async from jupyter_server (c.f. #4954).

@blink1073 blink1073 added this to the 0.34 milestone Aug 13, 2018
@blink1073 blink1073 self-assigned this Aug 13, 2018
@blink1073 blink1073 changed the title Switch to python 3.4+ Switch to python 3.5+ Aug 13, 2018
Copy link
Member

@ian-r-rose ian-r-rose left a comment

Beautiful. The future is here, and the __future__ has gone.

Is this ready to go?

Loading

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Aug 14, 2018

Ah, needs a rebase I suppose.

Loading

@blink1073 blink1073 merged commit 40530f8 into jupyterlab:master Aug 14, 2018
1 of 2 checks passed
Loading
@blink1073 blink1073 mentioned this pull request Aug 17, 2018
@blink1073 blink1073 deleted the py3-only-update branch Sep 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants