Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Mathjax2 typesetter to library package #5259

Merged
merged 3 commits into from Sep 3, 2018

Conversation

@vidartf
Copy link
Member

@vidartf vidartf commented Sep 3, 2018

  • Splits library code part of @jupyterlab/mathjax2-extension into the new package @jupyterlab/mathjax2.
  • Moves materialcolors.css from application to apputils.

Closes #5257.

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Sep 3, 2018

Looks good to me, thanks @vidartf

@ian-r-rose ian-r-rose merged commit 71a18ae into jupyterlab:master Sep 3, 2018
2 checks passed
@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Sep 3, 2018

We might consider moving to the npm package for MathJax2, probably with lazy loading, allowing us to remove the special-casing for MathJax.

@vidartf vidartf deleted the mathjax-lib branch Sep 4, 2018
@blink1073 blink1073 added this to the 0.35 milestone Sep 28, 2018
@blink1073 blink1073 mentioned this pull request Sep 28, 2018
31 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants