Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5181: Remove maxlength so as to not cut off kernel name in kernel selector dialog. #5260

Merged
merged 1 commit into from Sep 4, 2018
Merged

Conversation

@apsknight
Copy link
Member

@apsknight apsknight commented Sep 3, 2018

This PR fix #5181

Removed maxLength variable so as to remove the concept of trimming the kernel name and appending ... in it. Now the kernel name appears without any trimming in kernel selector dialog.

@apsknight apsknight changed the title Fix #5181: Remove maxlength so as to not cut off kernel name in kernel selector fialog. Fix #5181: Remove maxlength so as to not cut off kernel name in kernel selector dialog. Sep 3, 2018
@apsknight
Copy link
Member Author

@apsknight apsknight commented Sep 3, 2018

@jasongrout @blink1073 - Please review this PR!

@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 4, 2018

LGTM, thanks!

@blink1073 blink1073 merged commit 122f698 into jupyterlab:master Sep 4, 2018
2 checks passed
@blink1073 blink1073 added this to the 0.35 milestone Sep 4, 2018
@apsknight apsknight deleted the remove_maxlength branch Sep 4, 2018
@blink1073 blink1073 removed this from the 0.35 milestone Sep 5, 2018
@blink1073 blink1073 added this to the 1.0 milestone Sep 5, 2018
@blink1073 blink1073 removed this from the 1.0 milestone Sep 28, 2018
@blink1073 blink1073 added this to the 0.35 milestone Sep 28, 2018
@blink1073 blink1073 mentioned this pull request Sep 28, 2018
31 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants