Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for disabled toolbar buttons #5278

Merged
merged 1 commit into from Sep 8, 2018
Merged

Conversation

@vidartf
Copy link
Member

@vidartf vidartf commented Sep 7, 2018

  • Adds setting enabled to ToolbarButtonComponent.
  • Set it from isEnabled for CommandToolbarButtonComponent.
@vidartf
Copy link
Member Author

@vidartf vidartf commented Sep 7, 2018

While this behavior was present previously, it was lost in #5117.

Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 added this to the 1.0 milestone Sep 7, 2018
@blink1073 blink1073 merged commit be8890d into jupyterlab:master Sep 8, 2018
2 checks passed
@vidartf vidartf deleted the toolbar-enabled branch Sep 8, 2018
@blink1073 blink1073 removed this from the 1.0 milestone Sep 28, 2018
@blink1073 blink1073 added this to the 0.35 milestone Sep 28, 2018
@blink1073 blink1073 mentioned this pull request Sep 28, 2018
31 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants