Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide quit entry for older notebook versions. #5280

Merged
merged 1 commit into from Sep 8, 2018
Merged

Hide quit entry for older notebook versions. #5280

merged 1 commit into from Sep 8, 2018

Conversation

@fcollonval
Copy link
Member

@fcollonval fcollonval commented Sep 8, 2018

Remove quit entry for older notebook versions instead of turning it on as introduced in #5252.

Reason: API end point api/shutdown is not existing for version prior to 5.1 and the option quit_button and the addition of a button in the UI was introduced in 5.5. So with this modification, the quit entry is only present for notebook >=5.5.

@blink1073 blink1073 added this to the 0.34.x milestone Sep 8, 2018
@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 8, 2018

Thanks!

@blink1073 blink1073 merged commit 64384fc into jupyterlab:master Sep 8, 2018
2 checks passed
@blink1073 blink1073 added the bug label Sep 8, 2018
@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 8, 2018

Released in 0.34.8.

@fcollonval fcollonval deleted the quit-compatibility branch Sep 9, 2018
@blink1073 blink1073 mentioned this pull request Sep 21, 2018
@jasongrout jasongrout removed this from the 0.34.x milestone Oct 1, 2018
@jasongrout jasongrout added this to the 0.35 milestone Oct 1, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants