Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand JupyterLab.IOptions to allow for custom DocumentRegistry, CommandLinker, ServiceManager to be passed into app #5291

Merged
merged 1 commit into from Sep 12, 2018

Conversation

@adobs
Copy link
Contributor

@adobs adobs commented Sep 11, 2018

expand JupyterLab.IOptions to allow for custom DocumentRegistry, CommandLinker, ServiceManager to be passed into app

…andLinker, ServiceManager to be passed into app
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 11, 2018

Fixes #4972

@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 12, 2018

Thanks!

@blink1073 blink1073 merged commit 9b2e915 into jupyterlab:master Sep 12, 2018
2 checks passed
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 12, 2018

meeseeksdev backport to 0.34.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Sep 12, 2018
…custom DocumentRegistry, CommandLinker, ServiceManager to be passed into app
@blink1073 blink1073 removed this from the 1.0 milestone Sep 28, 2018
@blink1073 blink1073 added this to the 0.35 milestone Sep 28, 2018
@blink1073 blink1073 mentioned this pull request Sep 28, 2018
31 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants