Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax highlighting for markdown lists. #5297

Merged

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Sep 12, 2018

Fixes #2741. This necessitated a deeper dive into codemirror themes than expected.

Before:
image

image

After:
image
image

@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented Sep 12, 2018

If anyone has any ideas as to why the doc tests are failing, I would love some input.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 12, 2018

Looks like we might have to pin the sphinx version...

@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 12, 2018

Sphinx 1.8 was released today.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 13, 2018

Sphinx is being pinned in #5306, merging this one. Thanks!

@blink1073 blink1073 merged commit f8a4b91 into jupyterlab:master Sep 13, 2018
1 of 2 checks passed
@blink1073 blink1073 removed this from the 1.0 milestone Sep 28, 2018
@blink1073 blink1073 added this to the 0.35 milestone Sep 28, 2018
@blink1073 blink1073 mentioned this pull request Sep 28, 2018
31 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants