Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select focus #5324

Merged
merged 2 commits into from Sep 16, 2018
Merged

Fix select focus #5324

merged 2 commits into from Sep 16, 2018

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Sep 16, 2018

Fixes #2995. This is tricky: Firefox apparently uses two different code-paths for select elements depending on whether multiprocessing is enabled. In one of the codepaths, events are fired slighly differently, where the target is the SELECT in one and the OPTION in the other. We were defocusing the SELECT inadvertently in one of the codepaths.

Also fixes #5168. Straightforward CSS change.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 16, 2018

Thanks!

@blink1073 blink1073 merged commit b6a6862 into jupyterlab:master Sep 16, 2018
1 of 2 checks passed
@jasongrout jasongrout removed this from the 1.0 milestone Oct 1, 2018
@jasongrout jasongrout added this to the 0.35 milestone Oct 1, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants