Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new optional splash screen parameter to show a light or dark splash screen. #5339

Merged
merged 1 commit into from Sep 21, 2018

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 19, 2018

Use this parameter when a theme changes to show a splash screen matching the theme (light for light themes, dark for dark themes).

Fixes #5338

The light splash screen stays the same as the current default splash screen. The dark screen uses md-grey-800 for the background. In the dark splash screen, the moons are actually white, but appear a bit shaded here from the debugger pausing the page so I could get a screenshot. See the video below for a better representation.

screen shot 2018-09-18 at 10 43 21 pm

theme

CC @ellisonbg, @tgeorgeux

…lash screen.

Use this parameter when a theme changes to show a splash screen matching the theme (light for light themes, dark for dark themes).

Fixes jupyterlab#5338
Copy link
Member

@blink1073 blink1073 left a comment

Nice, thanks!

@jasongrout jasongrout requested a review from tgeorgeux Sep 20, 2018
@blink1073 blink1073 removed this from the 1.0 milestone Sep 20, 2018
@blink1073 blink1073 added this to the 0.35 milestone Sep 20, 2018
Copy link
Contributor

@tgeorgeux tgeorgeux left a comment

This looks great to me! Significant improvement over what we had.

@afshin afshin merged commit 9413f4a into jupyterlab:master Sep 21, 2018
1 of 2 checks passed
@blink1073 blink1073 mentioned this pull request Sep 28, 2018
31 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants