Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use encodeURI instead of encodeURIComponent for shareable links #5340

Merged
merged 1 commit into from Sep 19, 2018

Conversation

@minrk
Copy link
Contributor

@minrk minrk commented Sep 19, 2018

tree URLs are documented as /lab/tree/path/to/notebook.ipynb (the result of encodeURI) not /lab/tree/path%2Fto%2Fnotebook.ipynb (the result of encodeURIComponent).

I suspect this was the intended behavior, as it's what's documented and what nbclassic does.

I couldn't find the right place to put a test, but I was able to test it by hand.

tree URLs are documented as `/lab/tree/path/to/notebook.ipynb` not `/lab/tree/path%2Fto%2Fnotebook.ipynb`
@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 19, 2018

Thanks! The docs failure is expected until Sphinx 1.8.1 is released.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 19, 2018

I'll backport this one.

@blink1073 blink1073 merged commit c4a9a70 into jupyterlab:master Sep 19, 2018
1 of 2 checks passed
blink1073 added a commit that referenced this issue Sep 19, 2018
tree URLs are documented as `/lab/tree/path/to/notebook.ipynb` not `/lab/tree/path%2Fto%2Fnotebook.ipynb`
@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 19, 2018

Released as 0.34.11.

@minrk
Copy link
Contributor Author

@minrk minrk commented Sep 19, 2018

Awesome, thanks!

@minrk minrk deleted the tree-url branch Sep 19, 2018
@jasongrout jasongrout added this to the 0.35 milestone Oct 1, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants