Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vega-Embed version #5342

Merged
merged 2 commits into from Sep 20, 2018
Merged

Fix Vega-Embed version #5342

merged 2 commits into from Sep 20, 2018

Conversation

@domoritz
Copy link
Member

@domoritz domoritz commented Sep 19, 2018

so that we don't yet update Vega-Lite to version 3 since Altair does not yet support it.

@domoritz
Copy link
Member Author

@domoritz domoritz commented Sep 19, 2018

hmm, I ran jlpm run integrity locally but it doesn't make a difference.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 20, 2018

Hmm, odd. I pushed the integrity change.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 20, 2018

Thanks!

@blink1073 blink1073 merged commit 5e69d40 into jupyterlab:master Sep 20, 2018
1 of 2 checks passed
@blink1073 blink1073 added this to the 0.35 milestone Sep 20, 2018
@domoritz
Copy link
Member Author

@domoritz domoritz commented Sep 20, 2018

Hmm, odd... and thanks!

@blink1073 blink1073 mentioned this pull request Sep 28, 2018
31 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants