Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch left right panel #5347

Merged
merged 5 commits into from Sep 22, 2018
Merged

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Sep 20, 2018

Alternative to #5104
Fixes #5054. Fixes #3707

This adds a new plugin that tracks, via the settings system, a set of overrides for left-ness or right-ness of sidebar items. It is relatively self-contained, and available as a context-menu item on the tabs.

@dhirschfeld
Copy link
Member

@dhirschfeld dhirschfeld commented Sep 20, 2018

This sounds great - can't wait to give it a go!

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Sep 21, 2018

Copy link
Member

@blink1073 blink1073 left a comment

Very nice, thanks!

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Sep 21, 2018

Trying to install on the plane - might not happen. This looks like a solid approach that is easy to reason about. From what I can tell, the content menu is on each tab, which I think is a good model. A few questions:

  • Does this provide the current (or future) option to let a user hide a side panel entirely (on a temporary basis)?
  • What do folks think about this state being store in settings versus the workspace?

This is an improvement and probably needs user testing/exploration before a release, so I am also find with us merging and iterating.

Copy link
Contributor

@ellisonbg ellisonbg left a comment

Finally was able to build locally. I think this is a good in a state we can merge and get feedback. We also might want to add items to the View menu for these actions, but that can come later.

@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented Sep 21, 2018

This does not provide an option to hide a tab at the moment: though I could imagine that this same plugin could do that in the future.

When I was thinking through this it seemed like the settings were the right place. If I want to customize the side-panel, I think I want it to be pretty sticky. These are widgets that are unique on the page (as opposed to documents or activities) and are very deliberately installed.

@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented Sep 21, 2018

We could also add this to the view menu, perhaps in a follow-up?

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Sep 21, 2018

I think the view menu sounds good, in a follow up.

@blink1073 blink1073 merged commit 426c7fe into jupyterlab:master Sep 22, 2018
1 of 2 checks passed
@blink1073 blink1073 mentioned this pull request Sep 22, 2018
@blink1073 blink1073 removed this from the 1.0 milestone Sep 28, 2018
@blink1073 blink1073 added this to the 0.35 milestone Sep 28, 2018
@blink1073 blink1073 mentioned this pull request Sep 28, 2018
31 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants