Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"go to line" action in text editor #5377

Merged
merged 3 commits into from Sep 25, 2018

Conversation

@perrinjerome
Copy link
Member

@perrinjerome perrinjerome commented Sep 25, 2018

Using default "Alt+G" shortcut in codemirror.

Screenshots

screencast- 2001-67c-1254-26-5e5f -8888-2018 09 25-09-32-35

@perrinjerome
Copy link
Member Author

@perrinjerome perrinjerome commented Sep 25, 2018

oops, closing for now. I have to take a look at these failing tests first.

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Sep 25, 2018

Feel free to reopen, and thanks for the PR @perrinjerome! The failing tests may be spurious, I have kicked the CI.

@perrinjerome
Copy link
Member Author

@perrinjerome perrinjerome commented Sep 25, 2018

Thanks. Locally jlpm run build:test && jlpm run test seems successful.

@perrinjerome perrinjerome reopened this Sep 25, 2018
@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 25, 2018

This is fantastic, thank you @perrinjerome!

@blink1073 blink1073 merged commit 3ea6a39 into jupyterlab:master Sep 25, 2018
2 checks passed
@blink1073 blink1073 added this to the 0.35 milestone Sep 25, 2018
@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 25, 2018

Congratulations on your first JupyterLab contribution 🎉!

@blink1073 blink1073 mentioned this pull request Sep 28, 2018
31 tasks
perrinjerome added a commit to perrinjerome/jupyterlab that referenced this issue Oct 21, 2018
find method does not exist for GoToLine
perrinjerome referenced this issue in perrinjerome/jupyterlab Oct 22, 2018
- introduce a `GridSearchService` to keep the state of incremental
search and provide a function to highlight cells matching search text.
- replace light / dark theme TextRenderer by a new `TextRenderConfig`
class holding the config of cell rendering for different states.
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants