Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make persist and save use save enabled #5391

Merged
merged 2 commits into from Sep 28, 2018
Merged

Conversation

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Sep 27, 2018

This changes the persist and save command in the filemenu and the persist notebook state command to be enabled only if the docmanager:save is command is enabled.

Now #5376 should also work for the persist and save file menu action, so that if the file is readonly it will be greyed out.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 28, 2018

Looks good. Thanks!

@jasongrout jasongrout merged commit 3a87d08 into master Sep 28, 2018
3 of 4 checks passed
@blink1073 blink1073 mentioned this pull request Sep 28, 2018
31 tasks
@jasongrout jasongrout deleted the persist-and-save-enable branch Oct 1, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants