Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the dark splash screen to be a bit darker. #5403

Merged
merged 1 commit into from Sep 28, 2018

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 28, 2018

This is a followup of #5339, making the dark splash screen a bit darker. I found over time that the lighter grey still looked out of place when fading to a much darker theme.

CC @ellisonbg, @tgeorgeux

Screenshots
Old:
olddarksplash

New:
darksplash

@jasongrout jasongrout added this to the 0.35 milestone Sep 28, 2018
Copy link
Member

@ian-r-rose ian-r-rose left a comment

I like it!

Loading

@tgeorgeux tgeorgeux merged commit 39e4b67 into jupyterlab:master Sep 28, 2018
0 of 2 checks passed
Loading
@blink1073 blink1073 mentioned this pull request Sep 28, 2018
31 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants