Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add karma_coverage_dir to KarmaTestApp #5415

Merged
merged 1 commit into from Oct 2, 2018
Merged

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Oct 2, 2018

The purpose of this change is to make it easier for third party JupyterLab extensions to reuse jupyterlab.tests.test_app and helper functions such as createClientSession from @jupyterlab/testutils.

Third party extensions can then follow a structure similar to the one used for the core extensions with the run-test.py files:

import os
from jupyterlab.tests.test_app import run_karma

HERE = os.path.realpath(os.path.dirname(__file__))

if __name__ == '__main__':
    run_karma(HERE, HERE)

The basic idea here is to avoid the hardcoded paths that are specific to the JupyterLab repo.

We briefly discussed it with @blink1073 on the Gitter channel. If Karma ends up being deprecated in favor of Jest, we might just want to clean it up and suggest using Jest for third party extensions as well.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 2, 2018

LGTM, thanks!

@blink1073 blink1073 merged commit 7a8b469 into jupyterlab:master Oct 2, 2018
2 checks passed
@blink1073 blink1073 added this to the 0.35 milestone Oct 2, 2018
@jtpio jtpio deleted the karma-test-app branch Oct 2, 2018
@jtpio
Copy link
Member Author

@jtpio jtpio commented Oct 2, 2018

Thanks, looks like it's going to make it to 0.35!

@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 2, 2018

Yep!

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants