Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'New Folder' item to filebrowser context menu #5447

Merged
merged 1 commit into from Oct 13, 2018

Conversation

@reevejd
Copy link
Member

@reevejd reevejd commented Oct 6, 2018

Adds a “New Folder” item to the file browser context menu (addresses half of #4280).

screen shot 2018-10-06 at 1 07 50 am

screen shot 2018-10-06 at 1 08 04 am

Copy link
Member

@blink1073 blink1073 left a comment

LGTM, thanks!

@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 6, 2018

@reevejd, it looks like we've picked up a merge conflict. I would have made the change myself, but this is your master branch. Mind rebasing?

@reevejd
Copy link
Member Author

@reevejd reevejd commented Oct 6, 2018

@blink1073 done

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Oct 6, 2018

Thanks for being flexible as we work on the kinks in this new filebrowser context menu @reevejd!

@blink1073 blink1073 merged commit 21312b2 into jupyterlab:master Oct 13, 2018
1 of 2 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants