Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the share link command to separate plugin #5460

Merged

Conversation

@quigleyj97
Copy link
Contributor

@quigleyj97 quigleyj97 commented Oct 9, 2018

Fixes #5388

As per the discussion on the ticket, I created another JupyterLabPlugin in the same package (@jupyterlab/filebrowser-extension). There's some things we could expand on (such as making it a more configurable link handler), but this will at least solve the immediate need and hopefully generate some user stories as to what more could be done for sharability.

This is my first PR to this project, so if you have any concerns (even if they're really minor!) please don't hesitate to share them.

This is to allow deployments to customize the link behavior handling by
disabling this plugin and substituting it with another implementation.
Copy link
Member

@blink1073 blink1073 left a comment

LGTM, thank you!

@blink1073 blink1073 added this to the 1.0 milestone Oct 9, 2018
@blink1073 blink1073 merged commit a270d8b into jupyterlab:master Oct 13, 2018
1 of 2 checks passed
@quigleyj97 quigleyj97 deleted the feature/share-link-extension branch Oct 13, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants