Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statusbar #5508

Merged
merged 410 commits into from Oct 18, 2018
Merged

Add statusbar #5508

merged 410 commits into from Oct 18, 2018

Conversation

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Oct 17, 2018

Closes #5352 by adding statusbar to core

To create initial commit (from this guide on https://medium.com/@porteneuve/mastering-git-subtrees-943d29a798ec):

git checkout master
git remote add statusbar https://github.com/jupyterlab/jupyterlab-statusbar.git
git checkout -b statusbar
git subtree add --prefix=packages/statusbar-extension statusbar master
git push --set-upstream --no-verify origin statusbar

Then we added the name to some shared spots and edited some config files in it to make them more homogenous to the rest of the extensions.

We can merge this if the tests all pass and then work on splitting sone of the core logic into a @jupyterlab/statusbar package and moving out the registration of statusbar items to their respective extensions.

declanvk and others added 30 commits Jul 13, 2018
initial CSS changes, implementing typsetyle
middle Area + fileUpload refactor
Also support signaling from the status item to the status bar for
context switches. Also set tsconfig for compilation in strict mode.
added groups for icon and text
richagadgil and others added 13 commits Sep 1, 2018
From the update-dependency script in @jupyterlab/buildutils:

update-dependency --minimal --regex '^@jupyterlab/' ^next

Then I edited the version of @types/react in package.json. Then I cleaned up the yarn.lock:

git clean -dfx
yarn install
yarn check
yarn-tools fix-duplicates yarn.lock > a
mv a yarn.lock
git clean -dfx
yarn install
Update for jlab 0.35 prerelease.
…542c22122a134dac337d'

git-subtree-dir: packages/statusbar-extension
git-subtree-mainline: cd265a4
git-subtree-split: b8e0a97
@saulshanabrook saulshanabrook changed the title WIP: Add statusbar Add statusbar Oct 17, 2018
@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Oct 17, 2018

This is a huge PR, and I agree we should merge ASAP and do cleanup/splitting in follow-ups. Thanks @saulshanabrook!

@saulshanabrook
Copy link
Member Author

@saulshanabrook saulshanabrook commented Oct 17, 2018

Thanks @ian-r-rose for the cleanup

@saulshanabrook saulshanabrook added this to the 1.0 milestone Oct 17, 2018
@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 18, 2018

Thanks!

@blink1073 blink1073 merged commit d158501 into master Oct 18, 2018
1 of 3 checks passed
@dhirschfeld
Copy link
Member

@dhirschfeld dhirschfeld commented Oct 18, 2018

Just confirming that for 0.35.2 we will no longer need to install the statusbar extension separately?

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Oct 18, 2018

I don't think this will be in a patch release, there is some more work to be done to further integrate this into the core.

@dhirschfeld
Copy link
Member

@dhirschfeld dhirschfeld commented Oct 18, 2018

Thanks for the info! I'll keep an eye on the releases then.

Also something to consider if I build from master - I've been considering spinning up a dev environment.

@vidartf vidartf deleted the statusbar branch Nov 27, 2018
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Feb 2, 2019
We still cannot retrieve more than 250 commits for a PR, so exceptionally large PRs such as jupyterlab#5508 will still need some special-casing.
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Feb 2, 2019
We still cannot retrieve more than 250 commits for a PR, so exceptionally large PRs such as jupyterlab#5508 will still need some special-casing.
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

7 participants