Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "New Text File" and "New Markdown File" to the palette #5512

Merged
merged 4 commits into from Oct 19, 2018

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Oct 18, 2018

To keep parity with "New Console", "New Terminal" and "New Notebook", which can be found both in "New > File > ..." and in the palette.

new-text-md-file-palette

@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 18, 2018

Nice! Mind adding a similar entry for a new markdown file, added in #5511?

@jtpio
Copy link
Member Author

@jtpio jtpio commented Oct 19, 2018

Sure thing!

@jtpio jtpio force-pushed the new-text-file-palette branch from 267d514 to 8d11741 Oct 19, 2018
@jtpio jtpio changed the title Add "New Text File" to the palette Add "New Text File" and "New Markdown File" to the palette Oct 19, 2018
@jtpio
Copy link
Member Author

@jtpio jtpio commented Oct 19, 2018

Rebased onto master and added New Markdown File to the palette.

For reference, there is a discussion happening in #5492 about what kind of files a user should be able to create from the menu (and to some extent from the palette).

@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 19, 2018

Nice, thanks again!

@blink1073 blink1073 merged commit d766470 into jupyterlab:master Oct 19, 2018
1 of 2 checks passed
@jtpio jtpio deleted the new-text-file-palette branch Oct 19, 2018
@jasongrout jasongrout added this to the 1.0 milestone Feb 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants