Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make button parameterized in showError #5513

Merged
merged 1 commit into from Oct 19, 2018

Conversation

@jaipreet-s
Copy link
Member

@jaipreet-s jaipreet-s commented Oct 18, 2018

The error message is defaulting to using the OK button scheme. In some cases, the WARN button scheme will be a better fit to make it clear to the user about the status.

Still defaults to using 1 OK button.

The error message is defaulting to using the OK button scheme. In some cases, the WARN button scheme will be a better fit to make it clear to the user about the status.

Still defaults to using 1 OK button.
@jaipreet-s
Copy link
Member Author

@jaipreet-s jaipreet-s commented Oct 18, 2018

Build passed in my fork but failed here

Copy link
Member

@blink1073 blink1073 left a comment

LGTM, thanks! I kicked the build, which has a few flaky tests.

@blink1073 blink1073 added this to the 1.0 milestone Oct 19, 2018
@blink1073 blink1073 merged commit a92202e into jupyterlab:master Oct 19, 2018
2 checks passed
@jaipreet-s jaipreet-s deleted the showerrormessage branch Oct 19, 2018
@jaipreet-s
Copy link
Member Author

@jaipreet-s jaipreet-s commented Oct 19, 2018

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants